Closed irregulator closed 4 years ago
yeap, the reasons make sense, i was also planing to start including them, because they help with stacktraces and how cython reconstruct the frames on a exception (trace back the error to the pyx file).
i'll look at the details later today and merge
@aleivag merged this pull request in facebookincubator/pystemd@a51e19e1abe65498f2d74aa540c7016716c3e846.
This commit adds .pyx files in MANIFEST.in, thus includes Cython files in pystemd source distribution (sdist).
The rationale behind this change is based on the following:
Additionally, current commit restructures setup.py external_modules by inversing their logic: if no pystemd/*.c files are found then cythonize is called on .pyx files. Both file types which will be anyway included in sdist.
[1]https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#distributing-cython-modules [2]https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html