search

systemd / pystemd

A thin Cython-based wrapper on top of libsystemd, focused on exposing the dbus API via sd-bus in an automated and easy to consume way.
GNU Lesser General Public License v2.1
414 stars 36 forks source link

requirements.txt: add cython as a dependency #46

Closed SamuelDudley closed 4 years ago

SamuelDudley commented 4 years ago

See issue 1 in #44

facebook-github-bot commented 4 years ago

Hi @SamuelDudley!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SamuelDudley commented 4 years ago

Clearly listed as a requirement in the read me.

aleivag commented 4 years ago

Of this set of commits, this is the only one i'm slightly opposed... basically cython is not needed to run pystemd, you could argue that nothing in req.txt is needed... and you would be right!

pypandoc is no longer needed and we should delete it, and mock was there for python2 compatibility, when we had python2 support, i would much ratter delet this file and update the README to be even more explicit because it already said

but in addition to previous requirements you'll need:

setuptools: Just use your distro's package (e.g. python-setuptools).
Cython: at least version 0.21a1, just pip install it or use the official installation guide from cython homepage to get latest http://cython.readthedocs.io/en/latest/src/quickstart/install.html.