search

systemd / pystemd

A thin Cython-based wrapper on top of libsystemd, focused on exposing the dbus API via sd-bus in an automated and easy to consume way.
GNU Lesser General Public License v2.1
411 stars 36 forks source link

only libsystemd-dev worked on ubuntu 16.04 #5

Closed iddoberger closed 6 years ago

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aleivag commented 6 years ago

Thanks for sharing this and working on pystemd, we really apreciate when people take their own time off to make it better.

I think what you want to do/say, is already encapsulated in the line before the one you edited, it says:

systemd headers: Chances are you already have this, normally is called libsystemd-dev on or systemd-devel, version needs to be at least v221.

that i think resumes what you are trying to accomplish on this PR.

you see libsystemd-dev is require only at compilation time, but libsystemd is require at compilation and runtime. that's why they are in different bullet point on the readme.

libsystemd-dev contains header and some macros that we use on pystemd, but once you compile it, you can actually remove it, or if you distribute binary artifacts (e.g. a wheel) your target system does not need to have libsystem-dev

libsystemd is the library that we link against, and is what does the heavy lifting between us and systemd.

if you want to change your PR to say this, that would be cool, if not, that is also fine, because i plan to update the docs to reflect this, and some other stuff

aleivag commented 6 years ago

Thanks for taking time off your day and publishing this PR, for the reasons explained above i'll close it, please feel free to either address the comment or summit a new pull requests

Thanks!