search

systemd / pystemd

A thin Cython-based wrapper on top of libsystemd, focused on exposing the dbus API via sd-bus in an automated and easy to consume way.
GNU Lesser General Public License v2.1
411 stars 36 forks source link

Fix double unref issue when using signal callback #8

Closed awarecan closed 4 years ago

awarecan commented 6 years ago

Fix https://github.com/facebookincubator/pystemd/issues/7#issuecomment-398924831

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

awarecan commented 6 years ago

CLA signed

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

awarecan commented 6 years ago

CI had failed on master...

davide125 commented 6 years ago

CI failure is unrelated, it's failing in master as well -- the version of systemd we have in Travis is too old

aleivag commented 6 years ago

Hey Thanks for submitting code, we really apreciate when people take their time to collaborate. and yeap, i need to fix travis, because i would like to make test to verify that we dont break you.

Please also see my comment in issue #7 about how there is another solution for this...

thanks

aleivag commented 4 years ago

this was addressed already, and no further discussion has been make