search

systemd / pystemd

A thin Cython-based wrapper on top of libsystemd, focused on exposing the dbus API via sd-bus in an automated and easy to consume way.
GNU Lesser General Public License v2.1
409 stars 36 forks source link

Adding semi-full support for pyproyect.toml #81

Closed aleivag closed 1 year ago

aleivag commented 1 year ago

This adds support for pyproject.toml and now makes pystemd iunstalled locally using pip install . this makes setup smaller, and it also makes our github action a bit simpler

aleivag commented 1 year ago

"i think" this fails for old version of setuptools... i can probably just add the name and the version to setup.py to make this issue go away....

PaulFurtado commented 1 year ago

@aleivag it looks like this PR has made it so installation via pip does not install lxml as a dependency anymore. I think that's potentially because lxml was removed from install_requires in setup.py, but you're not all-in on pyproject.toml yet.

This actually has downstream effects too: it appears that the 0.13.0 RPM that is in the EPEL yum repository dropped that dependency accordingly, so now CentOS 9 systems are getting a broken 0.13.0 install if lxml is not already present on the system.

aleivag commented 1 year ago

I'll check this in about an hour! Thanks for reporting it

On Thu, May 11, 2023, 12:01 PM Paul Furtado @.***> wrote:

@aleivag https://github.com/aleivag it looks like this PR has made it so installation via pip does not install lxml as a dependency anymore. I think that's potentially because lxml was removed from install_requires in setup.py, but you're not all-in on pyproject.toml yet.

This actually has downstream effects too: it appears that the 0.13.0 RPM that is in the EPEL yum repository dropped that dependency accordingly, so now CentOS 9 systems are getting a broken 0.13.0 install if lxml is not already present on the system.

— Reply to this email directly, view it on GitHub https://github.com/systemd/pystemd/pull/81#issuecomment-1544528298, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABISHTUFYGMJBRJQGUD6PDDXFUZOZANCNFSM6AAAAAAW6WKUWQ . You are receiving this because you were mentioned.Message ID: @.***>

aleivag commented 1 year ago

just published https://github.com/systemd/pystemd/pull/84 and followup discussion in matrix

PaulFurtado commented 1 year ago

Thanks for the quick update!