systemd / python-systemd

Python wrappers for systemd functionality
GNU Lesser General Public License v2.1
465 stars 66 forks source link

tests: check for errnos that sd_id128_get_machine actually returns #119

Closed keszybz closed 2 years ago

keszybz commented 2 years ago

Fixes #118.

mrc0mmand commented 2 years ago

Since initializing /etc/machine-id for the tests to pass shouldn't be necessary anymore, can you drop https://github.com/systemd/python-systemd/blob/dc1dae2eaa00e2369c366f80f9bcd3f729b7abca/.github/workflows/install.yml#L79-L80 from the CI stuff?

keszybz commented 2 years ago

OK, the tests pass, and with the second commit, we know that we're testing without machine-id, so I'm pretty sure this resolved the original issue.