search

systemed / potlatch3

OpenStreetMap editor for desktop
Other
26 stars 5 forks source link

close changeset with "Save" #9

Closed hakuchi closed 2 years ago

hakuchi commented 3 years ago

Potlach should close the changeset after pressing "Save". This prevent user from having to large changesets or changesets over the entire world.

Mappers not always think abbout pressing "C" before opening/editing something other.

jonpsp commented 3 years ago

I disagree. Potlatch always encouraged regular saving as it was unable to deal with editing something that someone else edited while the changeset was open. I find the way that iD closes the changeset on every save quite confusing.

I save quite regularly and this would mean I would create 10s-100s of changesets for the same session, but all those changesets would be logically connected with the same changeset comments.

Jon

On Sun, 10 Jan 2021, 00:28 hakuchi, notifications@github.com wrote:

Potlach should close the changeset after pressing "Save". This prevent user from having to large changesets or changesets over the entire world.

Mappers not always think abbout pressing "C" before opening/editing something other.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/systemed/potlatch3/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6V7FWZOXOQDQ2OKGUCALTSZDYBVANCNFSM4V37PZYQ .

systemed commented 3 years ago

I'll consider adding a checkbox to the Save dialogue that closes the changeset after saving (such that the checkbox persists with every save) if that's the user's choice.

I don't want to automatically close every changeset on save. Regular saving is to be encouraged because, as @jonpsp points out, it reduces the opportunity for editing conflicts, and just as crucially it reduces the risk of losing work from a program crash. Potlatch has for a long time warned you if you go more than 20 minutes without saving.

hakuchi commented 3 years ago

A checkbox where every user can decide if he will use "save and close" or "save only" sounds the perfect solution.

So if I edit something where I need more time I can use "save only" and if I go to fix error reports I can easy switch to "save and close"

BikePC commented 3 years ago

Agree to @hakuchi - give the user a choice "save and close" or "save only".

Remember there is also the keyboard shortcut "c" to close the current changeset. To be used when moving to a different editing area / session which needs different changeset comments.

systemed commented 2 years ago

P3 now has a "Close changeset" checkbox in the Save dialogue which, if selected, will automatically close after saving. This is persisted between changesets and editing sessions.

In addition, there's now a warning if you try to save into an existing changeset such that it would create a massive bbox (because I keep doing that...).

The Mac, AIR and Windows downloads are all updated.