search

systemed / tilemaker

Make OpenStreetMap vector tiles without the stack
https://tilemaker.org/
Other
1.44k stars 229 forks source link

Lua interop #604

Closed cldellow closed 8 months ago

cldellow commented 9 months ago

Replaced by #626

(This is meant to be merged after https://github.com/systemed/tilemaker/pull/623. Until then, you can see the lua-interop-specific diffs here: https://github.com/cldellow/tilemaker/compare/protozero...cldellow:lua-interop?expand=1)

A mix of tweaks to avoid Lua overhead - reading commit by commit is probably the easiest path to review.

systemed commented 9 months ago

All really good - thank you. I'll leave merging this one until we're ready to release a 3.0 as it's a breaking change for the Lua interface, but definitely useful savings.

cldellow commented 8 months ago

This has been rejigged to be based on #623, so it should be merged after that.

Updated timings for read phase:

great-britain, protozero vs this branch: 52s vs 41s (-21%) france, protozero vs this branch: 2m28s vs 1m58s (-20%)

There also a handful of new commits to reduce concurrency issues on larger machines.

cldellow commented 8 months ago

This is also unhappy merging against master due to squash commits - going to close and re-open with the relevant commits cherry-picked.