When I replaced #604 with #626, I botched extracting this part of the code. I had the trait, which taught kaguya how to serialize PossiblyKnownTagValue, but I missed updating the parameter type of Attribute to actually use it, so it was a no-op.
This PR restores the behaviour of avoiding string copies, but now that we have protozero's data_view class, we can use that rather than our own weirdo struct.
It also fixes an unrelated test build error in the way store test.
...and two issues to do with LayerAsCentroid's support for relation members.
systemed
commented
7 months ago
When I replaced #604 with #626, I botched extracting this part of the code. I had the trait, which taught kaguya how to serialize
PossiblyKnownTagValue, but I missed updating the parameter type ofAttributeto actually use it, so it was a no-op.This PR restores the behaviour of avoiding string copies, but now that we have protozero's data_view class, we can use that rather than our own weirdo struct.
It also fixes an unrelated test build error in the way store test.
...and two issues to do with LayerAsCentroid's support for relation members.
...and an issue with the Intersects PR.