systemed / tilemaker

Make OpenStreetMap vector tiles without the stack
https://tilemaker.org/
Other
1.46k stars 230 forks source link

Attribute(name, value, minzoom) writes attribute on all zoom levels #671

Closed Nakaner closed 7 months ago

Nakaner commented 8 months ago

The minzoom argument of the function Attribute(name, value, minzoom) is not working.

How to reproduce:

Ogrinfo will print a linestring geometry with a surface attribute. However, the Tilemaker process file says that the attribute is supposed to be written on zoom level 9 and larger only.

The bug was introduced by commit d62c480debf6c38cd5d2c6339bfaa995b05fb9f2 by @cldellow.

cldellow commented 8 months ago

Ack, thank you for diagnosing the breaking commit and for the excellent reproduction steps.

672 should fix that, and also adds tests to catch future regressions. I think minzooms greater than 7 were not being honoured correctly.