systemed / tilemaker

Make OpenStreetMap vector tiles without the stack
https://tilemaker.org/
Other
1.4k stars 226 forks source link

Empty strings are ok really #676

Closed systemed closed 5 months ago

systemed commented 5 months ago

Possibly the least consequential pull request in history...

Currently we trap empty strings in OsmLuaProcessing::Attribute. It is legitimate though to write an empty string value, and some styles may behave differently depending whether an attribute =="" or ==undefined - for example, the MBGL has operator will return true for the former, false for the latter.