Open Minion3665 opened 2 years ago
@Minion3665 I have made the repo public
Looks good, not entirely sure about eradicate
as it may give a false positive but I'll trust it.
You could use the command poetry install --only dev
instead. This will install all dev dependencies which can then be run. Or place all linting/reformatting in its own dependency group (https://python-poetry.org/docs/master/managing-dependencies/) and use the command poetry install --only reformat-lint
.
Looks good, not entirely sure about
eradicate
as it may give a false positive but I'll trust it.You could use the command
poetry install --only dev
instead. This will install all dev dependencies which can then be run. Or place all linting/reformatting in its own dependency group (python-poetry.org/docs/master/managing-dependencies) and use the commandpoetry install --only reformat-lint
.
I'll take a look at using poetry.
I think even if eradicate does give an occasional false positive it isn't much of an issue as we'll still have the old commits in our history, so I'm not too worried about the chance of that happening
I'll take a look at using poetry.
Don't worry too much about using poetry but add the packages used to the dev dependencies so they could be run/pre-checked before pushing.
I think even if eradicate does give an occasional false positive it isn't much of an issue as we'll still have the old commits in our history, so I'm not too worried about the chance of that happening
That would be annoying to do but fair
On github side we will
This change partially-fixes #1 and fixes #10