systemetric / shepherd-2

A rewrite of shepherd
Apache License 2.0
4 stars 0 forks source link

Add github actions for CI #17

Open Minion3665 opened 2 years ago

Minion3665 commented 2 years ago

On github side we will

This change partially-fixes #1 and fixes #10

shardros commented 2 years ago

@Minion3665 I have made the repo public

fenjalien commented 2 years ago

Looks good, not entirely sure about eradicate as it may give a false positive but I'll trust it.

You could use the command poetry install --only dev instead. This will install all dev dependencies which can then be run. Or place all linting/reformatting in its own dependency group (https://python-poetry.org/docs/master/managing-dependencies/) and use the command poetry install --only reformat-lint.

Minion3665 commented 2 years ago

Looks good, not entirely sure about eradicate as it may give a false positive but I'll trust it.

You could use the command poetry install --only dev instead. This will install all dev dependencies which can then be run. Or place all linting/reformatting in its own dependency group (python-poetry.org/docs/master/managing-dependencies) and use the command poetry install --only reformat-lint.

I'll take a look at using poetry.

I think even if eradicate does give an occasional false positive it isn't much of an issue as we'll still have the old commits in our history, so I'm not too worried about the chance of that happening

fenjalien commented 2 years ago

I'll take a look at using poetry.

Don't worry too much about using poetry but add the packages used to the dev dependencies so they could be run/pre-checked before pushing.

I think even if eradicate does give an occasional false positive it isn't much of an issue as we'll still have the old commits in our history, so I'm not too worried about the chance of that happening

That would be annoying to do but fair