search

systemincloud / thriftr

Other
17 stars 0 forks source link

Getting code that defines R6 methods #2

Open randyzwitch opened 6 years ago

randyzwitch commented 6 years ago

Thanks for putting together this package, it's long overdue and looks great!

I can generate a thrift client using t_load and make_client, and it appears to be working. However, I want to modify the function definitions somewhat to clean up the interface.

Instead of having t_load actually define the R6 classes in my R session, is it possible to get the code dumped out to file like other Thrift parsers? I'm looking for something like this generated code:

https://github.com/omnisci/pymapd/tree/master/mapd

marekjagielski commented 6 years ago

Hi, Thanks. I must say that probably you are the first adopter of this library. So be aware that there are for sure a lot of issues. Contributions are welcome.

This library is inspired and in fact still not full clone of:

https://thriftpy.readthedocs.io/en/latest/ (https://github.com/eleme/thriftpy)

The main conception was that you can get thrift api without the need of code generation. However, if you find that it would we useful to have code dump I will leave this issue for future enhancement.