systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
955 stars 67 forks source link

feat: change pool noodle to use channels to prevent spamming pop #4520

Closed sprutton1 closed 1 week ago

sprutton1 commented 2 weeks ago

After a conversation with @fnichol we decided it would be better to use channels to pass work around here so we aren't hammering pop() in a bunch of threads and are instead just polling for work. We should be just as fast (if not faster) under load, but we'll be a lot quieter when sitting still. We limit total threads using a semaphore so we will block work until new slots appear.

sprutton1 commented 2 weeks ago

/try

sprutton1 commented 1 week ago

/try

sprutton1 commented 1 week ago

/try

sprutton1 commented 1 week ago

/try

sprutton1 commented 1 week ago

/try

sprutton1 commented 1 week ago

/try

sprutton1 commented 1 week ago

/try