search

systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
1.58k stars 261 forks source link

Annihilate reconciliation func remnants (again) #4535

Closed nickgerace closed 2 months ago

nickgerace commented 2 months ago

Description

This PR removes remnants of reconciliation funcs in the codebase... again. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you!

This is a second attempt (#4523 and #4454) and now works with existing graphs due to deserializing enums that contained reconciliation funcs.

zacharyhamm commented 2 months ago

Actually, I'm seeing a deserialization issue in the layer cache updates, going to track it down.

zacharyhamm commented 2 months ago

Actually, I'm seeing a deserialization issue in the layer cache updates, going to track it down.

nevermind, i had some branch weirdness, we're good here. should cause no serialization issues

nickgerace commented 2 months ago

Made the changes that we discussed.