systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
955 stars 67 forks source link

feat: don't throw 500s on action already enqueued #4545

Closed johnrwatson closed 1 week ago

johnrwatson commented 1 week ago

Tested locally, shown to throw 304 instead now when you intentionally API call add the same action twice, no 500 modal

< HTTP/1.1 304 Not Modified
< Access-Control-Allow-Origin: *
< content-type: application/json
< content-length: 102
< access-control-allow-credentials: true
< vary: origin, access-control-request-method, access-control-request-headers
< date: Wed, 11 Sep 2024 00:05:28 GMT
< connection: keep-alive
< 

This was causing grief in Production + metrics