search

systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
955 stars 67 forks source link

fix(dal): ensure DVU finishes after function failure #4570

Closed zacharyhamm closed 1 week ago

zacharyhamm commented 1 week ago

The condition for finishing the DVU after function failure was broken. This should ensure we always send StatusFinished events even if an execution fails.

Should close BUG-513

jhelwig commented 1 week ago

What was it about the previous logic that wasn't correct? It was trying to protect against reporting "done" when there are no independent IDs, but there are still functions running (for exmple, if we've gotten to the point of having started running all of the leaf nodes in the graph, and there is nothing else left in the dependency graph).