systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
955 stars 67 forks source link

Retain bindings when regenerating assets #4636

Open nickgerace opened 1 day ago

nickgerace commented 1 day ago

Description

This PR ensures that we retain func bindings when regenerating assets. Specifically, this fix handles the new paradigm where setValueFrom has been deprecated in the asset builder and intrinsic authoring has been added to the frontend (feature flagged at the time of writing).

The bug was caused by relying on the identity func when merging prototypes for both prop and socket output locations between two schema variants. They need to rely on the unset func instead or handle both intrinsics to make informed decisions about how to merge the prototypes.

This PR also fixes the tracing naming for the regenerate_variant function.