systeminit / si

The System Initiative software
https://systeminit.com
Apache License 2.0
1.59k stars 261 forks source link

Add audit database migrations #4977

Closed nickgerace closed 11 hours ago

nickgerace commented 20 hours ago

Description

This PR adds audit database migrations. They are explicitly not part of the ServicesContext nor DalContext.

This PR also moves the audit logs stream contents to a new submodule in the corresponding crate as well as deletes an unused NATS client method in sdf-server.

We also use the DBNAME constant for layer db configuration in sdf now, like we do with the audit database.

nickgerace commented 15 hours ago

For those curious: investigating those integration test failures locally. This PR should not have affected them, but it's possible that it did.

nickgerace commented 14 hours ago

From the investigation, these transient errors are not caused by changes in this PR. Adding to the merge queue.

nickgerace commented 14 hours ago

Removed and re-added because GitHub thought there were merge conflicts... there were none, but I rebased and force pushed anyway.

nickgerace commented 13 hours ago

/try

nickgerace commented 13 hours ago

/try

nickgerace commented 13 hours ago

@fnichol is going to watch over this and we will re-sync soon. We combed through the PR several times and believe the CI issues to be wholly unrelated at this time.

fnichol commented 12 hours ago

/try