systemjs / builder

SystemJS build tool
MIT License
465 stars 122 forks source link

buildStatic support for context without a global #812

Closed chrmod closed 7 years ago

chrmod commented 7 years ago

I'm building a sfx bundle to be run inside of Firefox process script.

In that context, explicit global object (ContentProcessMessageManager) does not happen to accessible via variable.

This PR aims to generate a bundle that will not throw errors on missing global in process script context.

Not sure if using this instead of self or global makes sense, but at least no errors are thrown and bundle works as expected. Please help to improve if there is a way.

Some mozilla docs:

chrmod commented 7 years ago

it does not really work atm, I'm going to update the PR as soon as it will also making the tests green.

chrmod commented 7 years ago

the problem was wrong version of uglify-js used for minify.sh

guybedford commented 7 years ago

Thanks, I'll post this out with the coming release cycle.