systemjs / builder

SystemJS build tool
MIT License
466 stars 122 forks source link

Sourcemap issue with beta.48 #849

Open ArmorDarks opened 6 years ago

ArmorDarks commented 6 years ago

JSPM 0.17.0-beta.48 (Windows 10) seems to introduce issue woth sourcemaps.

Here is how it looks before beta.48 on Windows (note the issue with paths, described in https://github.com/systemjs/builder/issues/845):

{
  "version": 3,
  "sources": [
    "jspm_packages/npm/jquery@3.3.1/dist/jquery.js",
    "src/file:/J:/_DEL_JSPM_TEST/src/dep.js",
    "src/file:/J:/_DEL_JSPM_TEST/src/app.js"
  ],
  "names": [...],
  "mappings": "...",
  "file": "build.js"
}

beta.48 fixed issue with paths on Windows, but now source map does not include package internal dependencies — only package itself and jspm_packages dependencies:

Here is how it looks with beta.48:

{
  "version": 3,
  "sources": [
    "jspm_packages/npm/jquery@3.3.1/dist/jquery.js",
    "src/app.js"
  ],
  "names": [...],
  "mappings": "...",
  "file": "build.js"
}
ArmorDarks commented 6 years ago

Archive with reproducted issue

guybedford commented 6 years ago

Are you sure this isn't the result of tree-shaking removing use of the dependency entirely?

ArmorDarks commented 6 years ago

Well, at least it shouldn't.

src/dep.js explicitly imported by src/app.js with import './dep, and final bundle has code from dep.js, but just does not exist in sourcemaps

Here is console output:

ohnh8t0

I also have another very large projects with good amount local package dependencies, and it has same issue — they all no longer appear in sourcemaps with beta.48.

guybedford commented 6 years ago

Odd, perhaps Rollup is just not outputting source maps dependencies that have invalid file paths?

ArmorDarks commented 6 years ago

Can't tell. The paths should be valid. I guess it would error about non-existing files if paths were invalid?

But I mostly certain it's an issue with Rollup.