systemjs / plugin-babel

SystemJS Babel Plugin
MIT License
83 stars 33 forks source link

babelOptions.sourceMaps or sourceMap? #13

Closed frankwallis closed 8 years ago

frankwallis commented 8 years ago

https://github.com/systemjs/plugin-babel/blob/master/plugin-babel.js#L49 uses sourceMaps:

var defaultBabelOptions = {
  modularRuntime: true,
  sourceMaps: true,
  es2015: true,
  stage3: true,
  moduleName: false
};

but https://github.com/systemjs/plugin-babel/blob/master/plugin-babel.js#L140 uses sourceMap:

    var output = babel.transform(load.source, {
      plugins: plugins,
      presets: presets,
      filename: load.address,
      sourceMap: babelOptions.sourceMap,
      inputSourceMap: load.metadata.sourceMap,
guybedford commented 8 years ago

Thanks, System sourceMaps were broken in Babel until the commit last night so there was no pressure on this. Working on it now.