search

systemjs / plugin-css

CSS loader plugin
MIT License
92 stars 60 forks source link

Fix root relative urls when there's no browserRootURL setting #138

Closed papandreou closed 6 years ago

papandreou commented 6 years ago

@montoriusz, could you test in your end that it fixes https://github.com/systemjs/plugin-css/pull/135#commitcomment-24411928?

montoriusz commented 6 years ago

@papandreou I'm sorry, I can't test it in the original working environment. It would require rebuilding a dependency project and we stick to an older version for now.

But I did review the change and it's ready to merge for me. The code looks a bit messy though. :-(

papandreou commented 6 years ago

Well, yeah, sorry about the mess. It would help to make a variant of the absUrl function that actually checks for absolute urls, rather than just root-relative ones. For now I just wanted to fix the problem that was reported and add the tests, though.

@guybedford, ping?

guybedford commented 6 years ago

@papandreou sure, I've published a 0.1.37.