Add custom nginx logrotate config

systemli / ansible-role-jitsi-meet

Ansible role to install & configure Jitsi Meet

GNU General Public License v3.0

44 stars 18 forks source link

Add custom nginx logrotate config #22

Closed xshadow closed 4 years ago

funkyfuture commented 4 years ago

some remarks:

the template modules is used though it is in fact a static artifact
it is opinionated, especially the rotate directive should be configurable
other components (jicofo, jvb, prosody) aren't customized, i adjusted these with post_tasks so far

xshadow commented 4 years ago

@funkyfuture you could share your customizations via a pull request.

funkyfuture commented 4 years ago

do you mean as part of the example playbook in the README?

funkyfuture commented 4 years ago

ah, i see your recent amendment. well, my approach is different. i have no preference, but only that it should be consistent. so, either configure all w/ the role. or leave the responsibility to the user.

xshadow commented 4 years ago

You are more then welcome to share any your code via PR, if you think this role can be improved

funkyfuture commented 4 years ago

yeah, but i didn't solve it within the role.