search

systemli / ansible-role-jitsi-meet

Ansible role to install & configure Jitsi Meet
GNU General Public License v3.0
44 stars 18 forks source link

Various changes #25

Closed funkyfuture closed 4 years ago

funkyfuture commented 4 years ago

these are some changes i applied for our deployments. feel free to cherry-pick what you deem useful and/or request improvements.

i don't know what is causing the error in the tests / how to fix it. this isn't happening when using it in our environment (on a fresh machine); prosody is running at that point and the reload is working.

t2d commented 4 years ago

Secret derivation: I like the idea, but it breaks compatibility with our current way of storing secrets. @0x46616c6b waht do you think about it.

Prosody uncoditional password change: Looks useful to me, but we can't have a task that changes all the time.

Prosody reload handler: Would be nice, but did break testing

Logrotate: I think we probably want to bring all this to syslog anyway.

The other things I either completely liked and cherry-picked or disliked.

funkyfuture commented 4 years ago

Prosody uncoditional password change: Looks useful to me, but we can't have a task that changes all the time.

that shouldn't be the case / the derived secrets should be deterministic.

Logrotate: I think we probably want to bring all this to syslog anyway.

journald as a target option would be nice too.

funkyfuture commented 4 years ago

i'd have some further small tweaks, but i'd rather close this pr as i doubt it'd get any more clearly here. so i'd prepare another pr. but i'm curious why you didn't pick d9d622917d9e33801f4586aef6e909e0e5f4212f, as this was the only change that i'd consider a bug fix.

t2d commented 4 years ago

i'd have some further small tweaks, but i'd rather close this pr as i doubt it'd get any more clearly here. so i'd prepare another pr. but i'm curious why you didn't pick d9d6229, as this was the only change that i'd consider a bug fix.

i just missed it. Fixed now. Yes, please multiple small PRs. Much easier to handle.

funkyfuture commented 4 years ago

i opened two follow-up prs.