search

systemli / ansible-role-jitsi-meet

Ansible role to install & configure Jitsi Meet
GNU General Public License v3.0
44 stars 18 forks source link

Minor tweaks #31

Closed funkyfuture closed 4 years ago

t2d commented 4 years ago

makeJsonParserHappy doesn't seem to be a problem in interface_config.js. Have you investigated why it was a problem in meet-config.js?

t2d commented 4 years ago

I cherry-picked the debsums things. But I want to keep the json parser happy. Every option has to end with a comma. Please make future PRs feature specific. I know, it's more work for you, but cherry-picking your changes is more work for me and much more complicated to discuss for all of us.

funkyfuture commented 4 years ago

But I want to keep the json parser happy. Every option has to end with a comma.

no, the last item in a json mapping / list must not be terminated with a comma. hence that item was added to prevent parsing errors when one of the option above that are commented out by default and is terminated with a comma is 'activated' w/o removing the comma. i guess there were several bug reports by people who didn't mind that.

makeJsonParserHappy doesn't seem to be a problem in interface_config.js.

yes, there's no actual problem w/ that. my thought was that it could be a problem if the application's implementation was changed to handle it similarly to jitsi-meet.js. also, its intended protection would never be needed with a template generated file.

Have you investigated why it was a problem in meet-config.js?

the key makeJsonParserHappy wasn't expected in that object and that threw an unhandled error iirc.