search

systemli / ansible-role-jitsi-meet

Ansible role to install & configure Jitsi Meet
GNU General Public License v3.0
44 stars 18 forks source link

Facilitation of general customization #37

Open funkyfuture opened 4 years ago

funkyfuture commented 4 years ago

please see the provided docs section and commit messages for details. i hope that wraps it all up.

t2d commented 4 years ago

Thank you for your PR. Can you please split it into two, so we can discuss the changes separately? Generally speaking we're trying to stay as close as possible to upstream. So while your nginx changes look meaningful, I'm asking myself why not to patch it at https://github.com/jitsi/jitsi-meet

funkyfuture commented 4 years ago

i hope to finish other strictly nginx-related improvements tomorrow and then separate the first commit out.

Generally speaking we're trying to stay as close as possible to upstream.

i may be very biased by my experiences, but i often consider application developer's (web) server configurations as hinjerotzt to the point where it just works, but never is consistent or reasonable with regards to the employed technology. i'm fond of the intended paradigm, yet it doesn't necessarily make a good sachargument in practice.

I'm asking myself why not to patch it at https://github.com/jitsi/jitsi-meet

i had that in mind, but i was then surprised to find my result very close to the example there (the /usr/local/share/… part would make sense for upstream though). i assume that this role doesn't want to provide a possible multidomain deployment (and their proposal for that doesn't seem too smart to me, but i haven't studied that).