systemli / userli

Web application to (self-) manage email users and encrypt their mailboxes.
https://systemli.github.io/userli/
GNU Affero General Public License v3.0
65 stars 13 forks source link

Modernize Authentication and Repositories #556

Closed 0x46616c6b closed 9 months ago

0x46616c6b commented 9 months ago

We implemented an AbstractRepository to filter out soft-deleted entities by default. This logic is also used by authentication and hides the logic a bit. In our admin interfaces, we want to see deleted entities as well, and the AbstractRepository was not useful for that. So the only reason I could imagine is the login flow. Therefore, Symfony has the UserCheckerInterface where you can decide whether a User can login or not.

I also removed some methods in the Repositories that are not used in any other classes.

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

52.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud