Closed blackgeorge-boom closed 1 year ago
Sorry for changing the requested reviewer, I thought I could request more than one, but since this is a private repo and we don't have GitHub Teams, apparently I can't.
Thanks for the PR! Can you add the steps for running this tool in the README
Steps to run NPB Benchmark
part? Other than this, LGTM!
This should be ready now! @PeiMu
This is based on prior work by @compor with the
run_bmks.py
script.This runner class extends this functionality and also adds a build functionality (example config file provided).
We can extend this in the future with loggin, plotting, etc., by adding more calls to the
dispatch
method.I created a separate file (didn't modify the
run_bmks.py
, because the diff would be hard to make readable and I didn't have time). Sorry for the long PR. I can break it down if necessary.Also add this as a package tool, so that we can call it from everywhere in the project with
npb <options>...
.Let me know what you think.
We can squash and merge.