Open ashu-dadhich opened 7 years ago
@sandarumk I also wanted to confirm is this the link of mock up? https://github.com/systers/FirstAide-Android/blob/develop/docs/design/mockup.pdf
The link to the mockup is correct. But implementation can be slightly different in some places. There are few third party libraries which will allow you to do the same. Can you do an analysis selecting few rather than going forward with one. So first what you have to do is this.
ok @sandarumk I will do an analysis and then get back to you.
I suggested this library because I used it in an app for some university and it worked fine.
Thank you.
Justification Library Comparison.pdf Yes @sandarumk you were right I found a good library and it works better then the one suggested by me. I have attached a pdf please have a look at it. Thank you.
I forgot to add one thing through it we can correct the hyphenation problem as well.
Can you include a table at the end of your document comparing the libraries you considered having them side by side?
ok i will @sandarumk
Justification Library Comparison.pdf Comparison table included
@sandarumk is the comparison table which I have included in the document sufficient or should I add more fields for their comparison. Thank you
In a document perspective, it has a lot to improve. But for this issue, that comparison is enough. You can start working on this and sending the PR.
Thank you @sandarumk and I will improve my documentation style.
@sandarumk I have a small doubt. In 1-2 fragments their is a bit of non-uniformity in spacing. Like for eg:
So In those fragments should continue with justification or use left allignment. Thank you
I am sorry for being late in this PR actually I hit some road-blocks while doing this issue. But now I have overcome them and will send a PR by Monday.
How many fragments does this happen?
Its currently happening in 4 fragments out of approx 36 fragments.
Any special reason this is happening with the said fragments?
Actually the reason for it is the word size.
I suggest I will attach a document containing all the pics of the fragments along with the PR. So it would be more easier for you to judge.
sure go ahead
Thanks a lot.
Summary Aligning the text to justified would give the app a more clutter free and cleaner look.
Observed Output
Expected Output
How do i propose to do it
I request a 3rd party dependency for it. Please refer to the link below. https://github.com/programingjd/justified
the only change we would be required to do is change in textview.xml:
to
<com.uncopt.android.widget.text.justify.JustifiedTextView xmlns:android="http://schemas.android.com/apk/res/android" />