systers / FirstAide-Android

FirstAide is a application to help the Peace Corps Volunteers who are victims of sexual harassment.
23 stars 104 forks source link

Suggestion: Aligning text to justified instead of left aligned #337

Open ashu-dadhich opened 7 years ago

ashu-dadhich commented 7 years ago

Summary Aligning the text to justified would give the app a more clutter free and cleaner look.

Observed Output image

Expected Output image

How do i propose to do it

ashu-dadhich commented 7 years ago

@sandarumk I also wanted to confirm is this the link of mock up? https://github.com/systers/FirstAide-Android/blob/develop/docs/design/mockup.pdf

sandarumk commented 7 years ago

The link to the mockup is correct. But implementation can be slightly different in some places. There are few third party libraries which will allow you to do the same. Can you do an analysis selecting few rather than going forward with one. So first what you have to do is this.

  1. Choose few third party libraries which do the same.
  2. Compare and contrast them
  3. Choose one and give your justification. You can do this in a document and attach it here or you can use the commenting space too.
ashu-dadhich commented 7 years ago

ok @sandarumk I will do an analysis and then get back to you.

I suggested this library because I used it in an app for some university and it worked fine.

Thank you.

ashu-dadhich commented 7 years ago

Justification Library Comparison.pdf Yes @sandarumk you were right I found a good library and it works better then the one suggested by me. I have attached a pdf please have a look at it. Thank you.

ashu-dadhich commented 7 years ago

I forgot to add one thing through it we can correct the hyphenation problem as well.

sandarumk commented 7 years ago

Can you include a table at the end of your document comparing the libraries you considered having them side by side?

ashu-dadhich commented 7 years ago

ok i will @sandarumk

ashu-dadhich commented 7 years ago

Justification Library Comparison.pdf Comparison table included

ashu-dadhich commented 7 years ago

@sandarumk is the comparison table which I have included in the document sufficient or should I add more fields for their comparison. Thank you

sandarumk commented 7 years ago

In a document perspective, it has a lot to improve. But for this issue, that comparison is enough. You can start working on this and sending the PR.

ashu-dadhich commented 7 years ago

Thank you @sandarumk and I will improve my documentation style.

ashu-dadhich commented 7 years ago

@sandarumk I have a small doubt. In 1-2 fragments their is a bit of non-uniformity in spacing. Like for eg: image

So In those fragments should continue with justification or use left allignment. Thank you

ashu-dadhich commented 7 years ago

I am sorry for being late in this PR actually I hit some road-blocks while doing this issue. But now I have overcome them and will send a PR by Monday.

sandarumk commented 7 years ago

How many fragments does this happen?

ashu-dadhich commented 7 years ago

Its currently happening in 4 fragments out of approx 36 fragments.

sandarumk commented 7 years ago

Any special reason this is happening with the said fragments?

ashu-dadhich commented 7 years ago

Actually the reason for it is the word size.

ashu-dadhich commented 7 years ago

I suggest I will attach a document containing all the pics of the fragments along with the PR. So it would be more easier for you to judge.

sandarumk commented 7 years ago

sure go ahead

ashu-dadhich commented 7 years ago

Thanks a lot.