search

systers / FirstAide-Android

FirstAide is a application to help the Peace Corps Volunteers who are victims of sexual harassment.
23 stars 104 forks source link

Adding Chrome Custom Tabs to open any URL #410

Open harshitagupta30 opened 7 years ago

harshitagupta30 commented 7 years ago

Currently, to open any link/URL in the application we redirect it to the browser. We can add chrome custom tab functionality to open the websites within the app which are more optimized, secure and load content faster as compared to web view.

@sandarumk What's your thought on this?

rohands commented 7 years ago

@harshitagupta30 thank you for your suggestions, this is a good idea. However, this is not currently required in the current implementation. Please feel free to include this enhancement in case you're planning to apply for this project.

sandarumk commented 7 years ago

This is actually a good suggestion. I would like to come back to this and explore more on this. This currently works only when chrome is installed, but we can have CustomTabFallback and make it open in another browser as well. Let's keep this onhold and comeback once the GSoC application period is over and the repo is back to normal. Then we can discuss whether to have this in app or not.