Closed lunayach closed 6 years ago
It is having the commit for part 1, because that was needed for this PR.
@lunayach Please address all the issues in this PR and resolve the conflicts too.
Addressed comments.
Addressed the issues.
The casing is all over the place in this pr. Please make sure you check it.
@lunayach please try completing all activities one by one and see if you are able to navigate without any issues. I am seeing a lot of issues with the navigation from one activity to the next
@Raxerz done the changes.
@shreyans29 please check now.
@lunayach Please reply to the specific comments. I can't figure out which one is resolved. And the main thing about all the caps and all.. it seems you haven't addressed that. Please check again.
@shreyans29 Actually that was not breaking anything. Just an issue was there in naming Upper Case Variables. FIxed that.
Description
Added multiple levels in the following activities:
Fixes #138
Type of Change:
Code
Quality Assurance
User Interface
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?
All Karma and Mocha tests passed.
Checklist:
[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] Any dependent changes have been merged
[x] My changes generate no new warnings
[x] Any dependent changes have been published in downstream modules