systers / PC-Prep-Kit

PC Prep Kit is a web application aimed at educating Peace Corps Volunteers and increasing awareness about Malaria and its prevention techniques.
9 stars 34 forks source link

GSoC 2018 work #181

Closed shreyans29 closed 6 years ago

shreyans29 commented 6 years ago

Description

This PR includes the work done in GSoC 2018

Fixes # [ISSUE] GSoC 2017 code with

121 #122 #123 #124 #125 #126 #127 #128 #129 #130 #131 #132 #133 #134 #135 #136 #137 #138 #139 #152 #156 #159 #160 #163 #168

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Unit tests for both back end and angular code.

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

Raxerz commented 6 years ago

@lunayach there seems to be some issue with the mosquito assassinato game, the mosquitoes are not loading up. Can you please check?

lunayach commented 6 years ago

@Raxerz @shreyans29 @paavininanda @Buddhiprabha For the above issue, there is a very minor change required. Instead of 1, I need to have level in one statement in app.routing.ts. I guess, I somehow missed it while moving it to the prevention stage. Should I send a PR for this fix(Is it allowed after GSoC?)

Buddhiprabha commented 6 years ago

@Raxerz will the issue be solved when @lunayach's change is added? If yes, @lunayach should create an issue and send a PR to develop branch to fix it. Is it possible to add that PR to this PR then @Raxerz ?

Raxerz commented 6 years ago

@Buddhiprabha I made the change that @lunayach is referring to and it works fine. Wouldn't it be better if he raises a PR to gsoc18 and once it is merged, it will get reflected in this PR as well? The other way to go about it is that he raises a PR to develop branch and merging that first before we merge this so that the change gets reflected in this PR.

Also, @lunayach reduce the spray by 0.25 and not by 1, it reduces pretty quickly right now

Buddhiprabha commented 6 years ago

@Raxerz Okay, let's merge this PR and then @lunayach can raise an issue and fix in develop. It is okay if it's not reflected in this PR.

Raxerz commented 6 years ago

@Buddhiprabha Shall I merge this? Needed your confirmation before merging since this is going into master

Buddhiprabha commented 6 years ago

@Raxerz yes, please do.