search

systers / macc

Server side support platform for Peace Corps mobile applications.
http://macc.systers.org/
9 stars 51 forks source link

User can enter non alphanumeric characters in the name #221

Open mish24 opened 7 years ago

mish24 commented 7 years ago

screenshot from 2017-03-20 01-12-08 Validation has to be added to check whether the user doesn't enter something like '+', '|' anything in the first and last name areas, infact in any field that requires typing

GunpreetAhuja commented 7 years ago

Hey, I am sorry I worked on the issue without your approval. I didn't know if the generator of the issue is the solver by default. However, can I carry out the task?

amittbhardwj commented 7 years ago

@mish24 we can add a simple regex query in models, where we have defined the username field or we can simple use the django inbuilt user, which already have this validation implemented and hence following the django principle of DRY( Don't Repeat Yourself)

mish24 commented 7 years ago

@GunpreetAhuja Sorry, I would like to keep this!

medhach commented 7 years ago

@mish24 Submit a PR!

GunpreetAhuja commented 7 years ago

@medhach Can I go with this issue?

medhach commented 7 years ago

@GunpreetAhuja Sure go ahead

GunpreetAhuja commented 7 years ago

@medhach You can add this to milestone as well.