bphenriques
commented
8 years ago Teodor,
After analysing the code:
- Use the NSManagedObjectExtension;
- Move responsibilities where it is due and better placed;
- The work flow is not clear to the reader due to some confusion on the object management
- Move the non-generated NSManagedObject code to a extension as it will be deleted if you change the model and re-generate the class;
- There can't be a AchivementProperty without an achivement, right? Therefore, you can optimize and simply your code with the below suggestions. It will as well help improve your code testability
- Some computations can be removed with the below suggestions as well (e.g.,
let matchingProperties: [AchievementProperty]? = properties.filter { propertyNames.contains($0.name!) }); - You can simply some code by extending your enum and move code the Achievement class.
For example, if the AchievementsProperty is attached to a Achivement then the creation should be attached to it. You define and save(!) an property without it being attached to a achievement which could lead to bugs with misusage, for example, if you misspell the id which will impact negatively the app in production where you can't simply reset the device data. With that in mind there should be a method on Achievements called AddCondition/AddProperty that is responsible for appending a new condition to the existing ones assuring to one-to-many relation between Achievement and AchivementProperty. IMO, the id argument only adds unnecessary complexity.
I think you intended to move the Achivement and AchievementProperty to the achivementsManager to encapsulate. It is a good approach but you violated that encapsulation when you used that class on the ViewController.
With these thoughts in mind: You should delete those defineAchivement/defineAchivementProperty and create dedicated static methods on Achivement (static Create(...) -> Achivement) and AchivementProperty(static Create(...) -> AchivementProperty. However, leave the saving part to the achivementsManager.
Now for defining the achievement you would have to:
let achivement = Achivement.Create(...)
//add conditions
achivement.AddCondition(AchievementProperty.Create(...))
//receives, validates(maybe) and saves in the context
achivementsManager.defineAchivement(achievement)Notice that with this approach you can test each object individually as the core objects.
Please provide further description regarding the current state and what is missing from the final PR.