Closed teodorciuraru closed 8 years ago
Gender should be a UIValuePicker. Btw, some of these values might become optional in the future (I would suggest changing the backend so that it is easier to define which fields are optional and what are mandatory). Age should be a number value picker, location should use the same picker as being used in plan my trip.
There is no "Done" button on the keyboard to quickly dismiss the keyboard.
The user profile it is better if it is a horizontal paged view that when you press next, it goes to the next screen. As it is, the first screen fades out and the second screen fades in which is not the most fluid experience.
Regarding the rest, everything seems okay! 👍 I would prefer having the updated documentation comments in another PR though (it clutters the PR which is focused on User Profile).
This never happened to you before (according to previous PR). Why now? "Redundant conformance to protocol XYZ"
Summary
Info Hub
page view's controllers.Plan Trip
button being covered by another view in iPhone 4, iOS 8.4.TestsAchievementsManager
because, as for the last patch, it is more encapsulated and the only API to test is getting all the achievements.Classes
UserProfileViewController
Has been changed, code and UI, so now it allows the user to update his profile information after pressing the
Edit
button. The changes will be saved, only if they pass our validations, when pressingSave
.SetupScreenUserProfileViewController
A new setup screen that appears only when launching the app for the first time. It uses the
User
class to save the data regarding the user after validating it.User
A NSManagedObject that represents a User entity. It makes sure that there is only one user created and handles functions like creating, updating (
define()
), validating (validateData()
) and helpful miscellaneous (isUserAlreadyCreated()
).StringInternalExtensions
andNSDateInternalExtensions
Created in order to solve a bug regarding "Redundant conformance to protocol XYZ" when running the app tests. I managed to solve it by splitting the default
StringExtensions
file into itself andStringInternalExtensions
that is only targeting malaria (not the tests) so that the error message stops appearing. Same forNSDateExtensions
.LocationTextField
andGenderTextField
Two custom views that need almost no setup and can be (and needed to be) easily reused throughout the app (PlanMyTripVC, SetupScreenUserProfileVC, UserProfileVC).