Webhook to API - Githubissues

systopia / CiviProxy

A security proxy for CiviCRM

GNU Affero General Public License v3.0

7 stars 18 forks source link

Webhook to API #32

Closed bjendres closed 7 months ago

bjendres commented 5 years ago

Similar to #18 and #26, we want to proxy to be able to receive webhooks/callbacks and forward the configuration to the target system's API.

For that, this hook needs the following features:

multiple configurations, one default
IP/Range filter
parameter sources (POST/json, ...)
parameter sanitation
response processing (mapping of API response to HTTP status codes)

pbatroff commented 2 years ago

This is implemented and works well with correct configuration setup.

In here and here return values from the internal CiviAPI is exposed.

I would propose to return 200 here and log the error internally to civiproxy_log, since the webhook got parsed and forwarded to the API correctly.

@bjendres do you have an opinion here?

This was already implemented, since the civi http code isn't returned, but 200 is always returned

pbatroff commented 2 years ago

I think we can close here