systopia / CiviProxy

A security proxy for CiviCRM
GNU Affero General Public License v3.0
7 stars 18 forks source link

get / set magic_quotes_runtime removed in PHP 8.0 / 7.0 #64

Closed jofranz closed 3 months ago

jofranz commented 1 year ago

phpcs -p . --standard=PHPCompatibility --extensions=php --runtime-set testVersion 7.4-8.1

FILE: CiviProxy/proxy/libs/Cache/Lite.php
---------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------
 758 | ERROR | Function get_magic_quotes_runtime() is deprecated since PHP 7.4 and removed since PHP 8.0
 760 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0
 776 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0
 837 | ERROR | Function get_magic_quotes_runtime() is deprecated since PHP 7.4 and removed since PHP 8.0
 839 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0
 843 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0
---------------------------------------------------------------------------------------------------------

internal reference: 19712

pbatroff commented 10 months ago

I can confirm this, I just ran into this problem. Unfortunately the caching Library isn't maintained since 2019 and there aren't any solutions with that particular Library

@bjendres Imo we need a solution here, and I am curious that noone else ran into this

21 is related

pbatroff commented 3 months ago

Functions will only be called if function exists as far as I can see. General PHP8 compatibility is handled in #62