TreeView breaks structure of campaign

systopia / de.systopia.campaign

SYSTOPIA's Google Summer of Code project: CampaignManager

https://campaignmanager.systopia.de/

Other

6 stars 19 forks source link

TreeView breaks structure of campaign #34

Closed scardinius closed 7 years ago

scardinius commented 7 years ago

Scenario:

Open campaign with structure like this: root > only one subcampaign 1 level > [ first 2 level subcampagin, second 2 level subcampaign]
Click on button View Campaign Tree
Click on campaign first 2 level subcampaign or second 2 level subcampaign
Click on button View Root
- Structure is changed :(

bjendres commented 7 years ago

Thanks, @scardinius.

@mattwire Could you have a brief look at this? Does that affect our project as well?

mattwire commented 7 years ago

@scardinius: I think this commit fixes your problem? https://github.com/systopia/de.systopia.campaign/commit/d6a179332f956ccc84cbb18c9876c79c59aff36d

If it is working with that fix, I will merge that into master

scardinius commented 7 years ago

@mattwire @systopia thanks! That works fine!

mattwire commented 7 years ago

Merged commit to master

bjendres commented 7 years ago

Great job @mattwire!

One tiny performance remark: we could just check for dist <= 900 to avoid the costly Math.sqrt function. But it won't have a significant impact in this scenario anyway...