Add missing ts() function

systopia / de.systopia.campaign

SYSTOPIA's Google Summer of Code project: CampaignManager

https://campaignmanager.systopia.de/

Other

6 stars 19 forks source link

Add missing ts() function #6

Closed scardinius closed 8 years ago

scardinius commented 8 years ago

Hi,

I'm going to translate whole extension into Polish. Therefore I added missing ts() function.

By the way, do you know more user friendly solution for communition of extension dependency? campaigngoodies.php:36

bjendres commented 8 years ago

Hi. Great, thank you!

Could I ask you, possibly, to please do it "properly"? I know, I used the same (bad) approach in CiviSEPA, but the correct implementation would be the one you can see in https://github.com/systopia/de.systopia.householdmerge:

use {ts}string{/ts} instead of {{ts('string')}} in tpl files
the l10n folder contains the localisation for the extension's domain
the ts() and {ts}{/ts} functions get a domain attribute

This way it'll be much easier to install the localisation as well, as it comes right with the extension code.

scardinius commented 8 years ago

And now is it ok?

bjendres commented 8 years ago

And now is it ok?

Sorry, I have no means of testing it right now. If you feel confident, I'll merge it and we can fix it later if it turns out to be broken...

michau commented 8 years ago

I guess merging it would be most convenient - we'll get to translating the extension very soon, so it will be additionally tested by us - we'll submit additional PRs, if we find anything.

bjendres commented 8 years ago

@nikobo: Could you merge this please?