search

systopia / de.systopia.donrec

CiviCRM Donation Receipts Extension
GNU Affero General Public License v3.0
15 stars 26 forks source link

start to fix deprecated/removed CRM_Core_OptionGroup::getValue #164

Closed sleidig closed 1 year ago

sleidig commented 1 year ago

With the latest CiviCRM Core update the system is failing to load any contributions in profiles because the extension is using deprecated methods that have been removed now. This PR solved the immediate issue for us (regular CiviCRM functionality is working again). (--> also see https://github.com/systopia/de.systopia.donrec/issues/125)

I didn't have the chance yet to thoroughly test whether the donrec functionality is correctly implemented using the new methods here. And I am unsure what the correct BAO for some of the code is.

CiviCRM Developer Doc Reference: https://docs.civicrm.org/dev/en/latest/framework/pseudoconstant/ StackExchange question to get input how to do this correctly: https://civicrm.stackexchange.com/questions/44840/how-to-replace-deprecated-crm-core-optiongroupgetvalue-with-crm-core-pseudocon

bjendres commented 1 year ago

Thanks @sleidig. @jensschuppe Could you have a look at this?

sleidig commented 1 year ago

Closing this in favor of the official fix: PR #165