systopia / de.systopia.donrec

CiviCRM Donation Receipts Extension
GNU Affero General Public License v3.0
15 stars 26 forks source link

Fixes CiviCRM 5.60 compatibility issues #165

Closed bjendres closed 1 year ago

bjendres commented 1 year ago

Replaces long deprecated and finally abandoned Core code.

See #125

bjendres commented 1 year ago

Here's the current version (might still change until release): de.systopia.donrec-2.2-dev+af74a9733c6c0e.tar.gz

sleidig commented 1 year ago

This seems to resolve the errors we faced after the last CiviCRM update!

Out of curiosity (trying to understand the depths of CiviCRM development :wink: ): Why did you decide to implement some custom value fetcher instead of using CiviCRM core methods like \Civi\Api4 or CRM_Core_PseudoConstant?

bjendres commented 1 year ago

This has been released with 2.2-beta1

bjendres commented 1 year ago

Why did you decide to implement some custom value fetcher instead of using CiviCRM core methods like \Civi\Api4 or CRM_Core_PseudoConstant?

This problem is pretty wide-spread in our extensions, so we needed a 100% compatible method call. And the CRM_Core_PseudoConstant::getKey function is not compatible in all cases.