systopia / de.systopia.fastactivity

CiviCRM Extension for high performance activity features
Other
4 stars 8 forks source link

Fix issues with some operators in activity report #27

Closed pfigel closed 4 years ago

pfigel commented 4 years ago

This fixes a number of issues with the "Is not one of", "Is empty (Null)" and "Is not empty (Null)" operators for the "Campaign(s)", "Assigned To" and "Created By" fields. These operators previously did not work as the generated SQL was invalid.

Additionally, for the "Is not one of" operator, the query was changed so it included values with a NULL value, which is consistent with core behaviour.

This also ensures that values are properly escaped for SQL.

bjendres commented 4 years ago

Looks good, thanks @pfigel