search

systopia / de.systopia.fastactivity

CiviCRM Extension for high performance activity features
Other
4 stars 8 forks source link

Uninstalling fails - Call to undefined method CRM_Fastactivity_Page_Tab::disable() #43

Open jensschuppe opened 2 years ago

jensschuppe commented 2 years ago

During #39, more specifically with 2504d402c52999475aa54c60b5d2c76b1ecb567e, a regression was introduced, causing the extension not being uninstallable anymore with Error: Call to undefined method CRM_Fastactivity_Page_Tab::disable() in fastactivity_civicrm_disable() (Line 73 of /path/to/ext/de.systopia.fastactivity/fastactivity.php).

The call to CRM_Fastactivity_Page_Tab::disable() will most likely have to be replaced with a call to CRM_Fastactivity_Page_Tab::hideNativeActivityTab(false) instead.

This should be released with a hotfix release for the 1.3 branch, and not wait until 1.4.

ErikHommel commented 5 months ago

Fixed in my PR: https://github.com/systopia/de.systopia.fastactivity/pull/49