enotice on settings form

systopia / de.systopia.householdmerge

CiviCRM Extension to merge contacts into households

Other

3 stars 5 forks source link

enotice on settings form #9

Open eileenmcnaughton opened 5 years ago

eileenmcnaughton commented 5 years ago

I haven't double checked but I was checking settings in conjunction with https://github.com/civicrm/civicrm-core/pull/13048 & I'm pretty sure you will have an enotice on yours as $_settings is not defined - I would recommend changing from extends CRM_Admin_Form_Setting to just CRM_Core_Form - you are not really using functionality from the settings form and it's not really supported as an integration point - I think it could well be completely deleted in the future

bjendres commented 5 years ago

Thanks, @eileenmcnaughton, great initiative! I feel like I haven't looked at this code in ages....

eileenmcnaughton commented 5 years ago

@systopia sometimes looking at old code can be traumatic .....

bjendres commented 5 years ago

@systopia sometimes looking at old code can be traumatic .....

Indeed