PHP 8 compatibility - Githubissues

systopia / de.systopia.moregreetings

CiviCRM Extension for additional greetings

GNU Affero General Public License v3.0

4 stars 10 forks source link

PHP 8 compatibility #29

Closed abugey closed 1 year ago

abugey commented 1 year ago

updated CustomDataHelper
fixed ArgumentCountError: Too few arguments to function CRM_Moregreetings_Form_Settings::smartyErrorHandler()

jensschuppe commented 1 year ago

@bjendres Could you have a look at the changes to the CustomData implementation before merging?

bjendres commented 1 year ago

@bjendres Could you have a look at the changes to the CustomData implementation before merging?

The plan for the CustomDataHelper ist to just copy a fresh version from https://github.com/systopia/Custom-Data-Helper - all you have to do is adjust the namespace. It looks to me like that's what @abugey has done.

The feature set of the CustomDataHelper is very stable and this approach should not cause any issues.