Incompatibility with CIviCRM 5.60 - Blank page when saving new greetings

destrieux commented 1 year ago

Hi, I have a more greetings v1.1.0 extension running on a CiviCRM 5.60.0 I was able to define a first custom greeting field, update all contacts and successfully use it. When I tried to enter an additional one or modify the first one, pressing the save or save and apply buttons only returns a blank page Many thanks for your help

bjendres commented 1 year ago

When I tried to enter an additional one or modify the first one, pressing the save or save and apply buttons only returns a blank page

This might very well be ~related to~ the same problem as https://github.com/systopia/de.systopia.donrec/pull/165, an incompatibility with CiviCRM 5.60. It shouldn't be too much effort to fix this. Stay tuned.

destrieux commented 1 year ago

many thanks : )

-- Christophe Destrieux, Unité « Brain» UMR INSERM U1253, Université de Tours [ http://www.u930.tours.inserm.fr/ | http://www.u930.tours.inserm.fr/ ]

Service de Neurochirurgie et Laboratoire d'Anatomie - Faculté de Médecine - 10 Bd Tonnellé - 37032 Tours - France tel (33) 2 47 36 61 36 - fax (33) 2 47 36 62 07

----- Le 6 Mai 23, à 9:16, Björn Endres @.***> a écrit :

|| When I tried to enter an additional one or modify the first one, pressing the || save or save and apply buttons only returns a blank page | This might very well be related to [ | https://github.com/systopia/de.systopia.donrec/pull/165 | | systopia/de.systopia.donrec#165 ] , an incompatibility with CiviCRM 5.60. It | shouldn't be too much effort to fix this. Stay tuned.

| — | Reply to this email directly, [ | https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1537075745 | | view it on GitHub ] , or [ | https://github.com/notifications/unsubscribe-auth/A7UVW2Q4JGEVK2TJ2SLLRWTXEX3GHANCNFSM6AAAAAAXX37FOQ | | unsubscribe ] . | You are receiving this because you authored the thread. Message ID: | @.***>

bjendres commented 1 year ago

@destrieux Could you verify that de.systopia.moregreetings-1.2+1df4236ee4bfb.zip works as expected?

destrieux commented 1 year ago

Hi Björn unfortunately not : exact same behavior as before best

Christophe Destrieux

Chargé de mission don du corps du Collège Médical Français des Professeurs d’Anatomie Unité iBrain UMRS INSERM U1253, Université de Tours https://ibrain.univ-tours.fr/

Service de Neurochirurgie et Laboratoire d'Anatomie - Faculté de Médecine - 10 Bd Tonnellé - 37032 Tours - France tel (33) 2 47 36 61 36 - fax (33) 2 47 36 62 07

Le 9 mai 2023 à 11:26, Björn Endres @.***> a écrit :

@destrieux https://github.com/destrieux Could you verify that de.systopia.moregreetings-1.2+1df4236ee4bfb.zip https://github.com/systopia/de.systopia.moregreetings/files/11428358/de.systopia.moregreetings-1.2%2B1df4236ee4bfb.zip works as expected?

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1539588773, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2V7SDQEGWV34XGE5O3XFIETFANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

bjendres commented 1 year ago

Interesting. I think I'll need some sort of error message from the CiviCRM log, the PHP log, or the Drupal error log. Could you have a look?

bjendres commented 1 year ago

Also, which PHP version are you running?

destrieux commented 1 year ago

Hi Björn

I’m running PHP 7.4.33 (cli) (built: Nov 8 2022 11:40:37) ( NTS

When I try to save a new greeting :

no message written into ConfigAndLog
in /var/log/apache2/error_civi.log : looks like there is a memory allocation problem

[Wed May 10 11:42:46.448586 2023] [php7:warn] [pid 2554528] [client 10.81.99.121:64435] PHP Warning: call_user_func() expects parameter 1 to be a valid callback, no array or string given in /var/www/html/wordpress/wp-content/plugins/civicrm/civicrm/ext/de.systopia.moregreetings/CRM/Moregreetings/Form/Settings.php on line 197, referer: http://10.195.17.22/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Fmoregreetings&reset=1

[Wed May 10 11:42:46.860665 2023] [php7:error] [pid 2554528] [client 10.81.99.121:64435] PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 262144 bytes) in /var/www/html/wordpress/wp-content/plugins/civicrm/civicrm/ext/de.systopia.moregreetings/CRM/Moregreetings/Form/Settings.php on line 197, referer: http://10.195.17.22/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Fmoregreetings&reset=1

[Wed May 10 11:42:46.860919 2023] [php7:error] [pid 2554528] [client 10.81.99.121:64435] PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0, referer: http://10.195.17.22/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Fmoregreetings&reset=1

Best

Christophe Destrieux

Chargé de mission don du corps du Collège Médical Français des Professeurs d’Anatomie Unité iBrain UMRS INSERM U1253, Université de Tours https://ibrain.univ-tours.fr/

Service de Neurochirurgie et Laboratoire d'Anatomie - Faculté de Médecine - 10 Bd Tonnellé - 37032 Tours - France tel (33) 2 47 36 61 36 - fax (33) 2 47 36 62 07

Le 9 mai 2023 à 19:49, Björn Endres @.***> a écrit :

Interesting. I think I'll need some sort of error message from the CiviCRM log, the PHP log, or the Drupal error log. Could you have a look?

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1540608510, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2WVUASM5HU3UF3UN3TXFJ7TBANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

bjendres commented 1 year ago

PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line

Yes, this is a memory issue, so you'd have to increase the memory that a PHP process is allowed to use.

The other issue might still be there, too, but we won't know until it gets past the memory issue.

destrieux commented 1 year ago

Hi Björn, in wp-config.php, I added define('WP_MEMORY_LIMIT', ‘3G’) with no success :

[10-May-2023 13:08:49 Europe/Paris] PHP Warning: call_user_func() expects parameter 1 to be a valid callback, no array or string given in /var/www/html/wordpress/wp-content/plugins/civicrm/civicrm/ext/de.systopia.moregreetings/CRM/Moregreetings/Form/Settings.php on line 197

[10-May-2023 13:08:57 Europe/Paris] PHP Fatal error: Allowed memory size of 3221225472 bytes exhausted (tried to allocate 262144 bytes) in /var/www/html/wordpress/wp-content/plugins/civicrm/civicrm/ext/de.systopia.moregreetings/CRM/Moregreetings/Form/Settings.php on line 197

[10-May-2023 13:08:57 Europe/Paris] PHP Fatal error: Allowed memory size of 3221225472 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0

best

Christophe Destrieux

Chargé de mission don du corps du Collège Médical Français des Professeurs d’Anatomie Unité iBrain UMRS INSERM U1253, Université de Tours https://ibrain.univ-tours.fr/

Service de Neurochirurgie et Laboratoire d'Anatomie - Faculté de Médecine - 10 Bd Tonnellé - 37032 Tours - France tel (33) 2 47 36 61 36 - fax (33) 2 47 36 62 07

Le 10 mai 2023 à 12:25, Björn Endres @.***> a écrit :

PHP Fatal error: Allowed memory size of 268435456 bytes exhausted

bjendres commented 1 year ago

Can you reproduce the issue with only one simple moregreetings formula? Just to see if your specific template might be reason..

destrieux commented 1 year ago

Sure :

when I put just hello in the "more greetings 1 » box, it can save (I didn’t try to apply not to change all my contacts)
when I put the formyula I need in the same box {if $contact.gender_id == '1’} Madame {elseif $contact.gender_id == '2’} Monsieur {else} { All other cases } Madame, Monsieur {/if} I can also save the formula
by contrast if i put one of those in the "more greetings 2" box, then I get the white page

Christophe Destrieux

Chargé de mission don du corps du Collège Médical Français des Professeurs d’Anatomie Unité iBrain UMRS INSERM U1253, Université de Tours https://ibrain.univ-tours.fr/

Service de Neurochirurgie et Laboratoire d'Anatomie - Faculté de Médecine - 10 Bd Tonnellé - 37032 Tours - France tel (33) 2 47 36 61 36 - fax (33) 2 47 36 62 07

Le 10 mai 2023 à 14:16, Björn Endres @.***> a écrit :

Can you reproduce the issue with only one simple moregreetings formula? Just to see if your specific template might be reason..

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1542103414, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2VMQM5YDCK564ZBGYLXFOBI7ANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

jofranz commented 1 year ago

@destrieux Thanks for reporting back at us! We released a 1.2.0-beta2 version with some fixes. Would you mind giving this version another try and see if things improved?

destrieux commented 1 year ago

Many thanks I’m not sure to have time before the 15th of September but will do it asap Best

Le 30 août 2023 à 16:48, jofranz @.***> a écrit :

@destrieux https://github.com/destrieux Thanks for reporting back at us! We released a 1.2.0-beta2 https://github.com/systopia/de.systopia.moregreetings/releases/tag/1.2.0-beta2 version with some fixes. Would you mind giving this version another try and see if things improved?

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1699328957, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2VRQBITWBRBFRJIYM3XX5HD3ANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

destrieux commented 1 year ago

Hi Sorry for the delay Unfortunately 1.2.0-beta2 https://github.com/systopia/de.systopia.moregreetings/releases/tag/1.2.0-beta2 didn’t fix my problem Best

Le 30 août 2023 à 16:48, jofranz @.***> a écrit :

@destrieux https://github.com/destrieux Thanks for reporting back at us! We released a 1.2.0-beta2 https://github.com/systopia/de.systopia.moregreetings/releases/tag/1.2.0-beta2 version with some fixes. Would you mind giving this version another try and see if things improved?

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1699328957, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2VRQBITWBRBFRJIYM3XX5HD3ANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

jensschuppe commented 1 year ago

I was able to replicate the behavior, there seems to be a problem with our workaround for catching Smarty errors by replacing the error handler. I tried to fix that in #40. @destrieux would you be able to test that PR? You should be able to download it here if you need to.

destrieux commented 1 year ago

Hi Sorry no improvement; I still get a white page when trying to save or save and apply the new greetings Best and many thanks for your efforts

Le 25 sept. 2023 à 14:24, jensschuppe @.***> a écrit :

I was able to replicate the behavior, there seems to be a problem with our workaround for catching Smarty errors by replacing the error handler. I tried to fix that in #40 https://github.com/systopia/de.systopia.moregreetings/pull/40. @destrieux https://github.com/destrieux would you be able to test that PR? You should be able to download it here https://github.com/systopia/de.systopia.moregreetings/archive/7a0a976e98e21ca1a6d12ad26d4c1db0ca780034.zip if you need to.

— Reply to this email directly, view it on GitHub https://github.com/systopia/de.systopia.moregreetings/issues/37#issuecomment-1733606379, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7UVW2VEST4M22NTSESRMZLX4FZWNANCNFSM6AAAAAAXX37FOQ. You are receiving this because you were mentioned.

RoWo-DS commented 12 months ago

I have a similar (same?) problem with CiviCRM Core 5.64.4 and moregreetings 1.2.0.beta2. I get a white page with message

Service Temporarily Unavailable
The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

Web Server at [my webserver adress]

The following examples sum up to

To avoid the error, use smarty syntax with variable usage (smarty syntax without variable usage doesnt help you)
You may omit smarty syntax in one greeting maximum, you can choose which one
You get a workaround from that, see the last screenshot

I do not get the error with only one greeting grafik

I do not get the error with only one greeting, independently which one i use grafik

I do get an error with two greetings without smarty syntax grafik

I do not get an error with two greetings with smarty syntax grafik

I do not get an error with two greetings if only one of them is without smarty syntax grafik

I do get an error with three greetings if more than one of them are without smarty syntax grafik

I do get an error with three greetings if more than one of them are with smarty syntax but without variable usage grafik

I do not get an error with three greetings if they are with smarty syntax and with variable usage grafik

jensschuppe commented 11 months ago

Thanks, @RoWo-DS for the detailed steps to reproduce. This will need some more in-depth debugging, obviously, which we are unable to provide at present. As there seems to be a workaround, I'm adding the needs funding label, in case anyone wants to contract us for fixing this.

eptbertram commented 10 months ago

Noticed this behaviour on WordPress once, too. Drupal 7 works fine.

systopia / de.systopia.moregreetings

Incompatibility with CIviCRM 5.60 - Blank page when saving new greetings #37