search

systopia / de.systopia.osm

CiviCRM OpenStreetmap GeoCoding-Provider
2 stars 17 forks source link

Add state information to address if necessary and served by osm #9

Open niels-heinemann opened 8 years ago

niels-heinemann commented 8 years ago

Updates address with state information if it's unset and nominatim serves it.

Also adjusts maximum decimal places on lat/lon values to 10 to not exceed civi's field limit of 14.

I removed the TODO comment because I don't think any other fields nominatim propagates are useful. And if some will be, developers recognizing it may have a fresh look at nominatims portfolio.

bjendres commented 8 years ago

@nielosz: Thanks, great addition! I assume you tested this and it's working in your setup, correct?

Should I merge it now, or do you think it's better to wait if there's more little bugfixes like https://github.com/systopia/de.systopia.osm/pull/9/commits/ef0d6027b5eabf7dee65c7fae2e8a6b4ddf0aa3e?

niels-heinemann commented 8 years ago

@systopia, yeah, tested and found working. I don't think there will be many more fixes. But you could wait, if you want, because our needs are satisfied. Just would be nice if it's included in your next release.

bjendres commented 8 years ago

But you could wait, if you want, because our needs are satisfied.

I'll wait for another week, I think.

Just would be nice if it's included in your next release.

Definitely. Thanks again for the PR

bjendres commented 2 years ago

Hi @niels-heinemann. Sorry, this PR has dropped off our radar.

Is this something you still want to be added to the extension? If so, could you update the PR?