systopia / de.systopia.xcm

CiviCRM Extended Contact Matcher
Other
5 stars 10 forks source link

Contact Update Report/Update and Diff activity #63

Closed jaapjansma closed 2 months ago

jaapjansma commented 4 years ago

When one sets a override field and/or override details. Then this data is not added to the diff activity.

Expected behaviour The diff activity is created listing the old data and the submitted data The submitted data is stored at the contact, overriding existing data.

Current behaviour The data is overridden at the contact record but not listed in the diff activity.

jensschuppe commented 4 years ago

@bjendres Isn't that expected behavior, since the diff activity should only include changes that haven't been applied instantly by XCM?

Quoting from the docs:

This section defines, what to do when a contact has been identified by XCM, submitted data was different to the contact's current state, and those different properties have not been changed by XCM.

jaapjansma commented 4 years ago

Ah I could not find that. I did not know it was intended. However I have two clients who wants to see the applied changes. How should we proceed?

bjendres commented 4 years ago

Hm, the diff activity is explicitly designed to be an overview of the remaining differences. What you want, @jaapjansma, is some sort of a update report - correct? This should be a completely separate feature then, don't you agree?

jaapjansma commented 4 years ago

Yeah what you call an update report is what I need. So how to implement this? Add an extra section for update report or a drop down option? under diff activity (which also contains the i3val)

jaapjansma commented 4 years ago

What about this?

Screenshot_20200619_154706

And the help text:

Screenshot_20200619_154716

bjendres commented 4 years ago

@jaapjansma could we move this discussion to #64?

bjendres commented 4 years ago

(and: I would personally clone the "Difference Handling" section to a "Updates Performed" section)

jaapjansma commented 4 years ago

I have updated the PR with an option to set the status and renamed the drop down options. Screenshot_20200619_163008

jaapjansma commented 4 years ago

I have renamed the handlers to: