systopia / de.systopia.xcm

CiviCRM Extended Contact Matcher
Other
5 stars 10 forks source link

Contact Update Report #64

Closed bjendres closed 2 months ago

bjendres commented 4 years ago

You can make a good case for wanting to know what parts of your contact has been changed by XCM. Therefore, there should be an option to generate an activity with the actual changes applied to the contact, pretty much like the diff activity does for remaining differences.

bjendres commented 4 years ago

@jaapjansma is this what you had in mind with #62?

jaapjansma commented 4 years ago

yes but then per contact.

bjendres commented 4 years ago

yes but then per contact.

Isn't this always 'per contact'?

bjendres commented 4 years ago

After talking to @jaapjansma, I believe his suggestion suggestion makes sense, because this is the only way to have a mixed activity with applied and pending changes.

jensschuppe commented 4 years ago

Will updated and pending changes be distinguishable in the activity? ~Does it make sense to provide an "Update activity" as well (since that'd be the same code - just in case, someone wants that, too)?~

~I'd also vote for clear descriptions of what is being recorded with those options - there has been some confusion in the past, apparently.~ Sorry, didn't notice there's already some work done on that.

jaapjansma commented 4 years ago

No the activity record the original data and the submitted data without indicating whether the changes have been applied or not. But that make sense probably in the context of the site user because it is also their configuration.

bjendres commented 4 years ago

Maybe we should find better labels for the two options. "Update and Difference Activity" sounds confusing compared to "Diff Activity". I would suggest:

There might also be a point in adding the "Activity Status" field in this context. Pending makes sense for the "Unresolved Differences", but if you use the "Contact Value Comparison" for documentation only, you might want Completed...

Sorry for scope-creeping, @jaapjansma ...

jaapjansma commented 4 years ago

I have renamed the handlers. See PR #63

jensschuppe commented 3 years ago

Since we're in beta phase for 1.8, this will have to wait until 1.9.